Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert log test data through sinks #86

Open
mo-esmp opened this issue Aug 23, 2023 · 1 comment · May be fixed by #114
Open

Insert log test data through sinks #86

mo-esmp opened this issue Aug 23, 2023 · 1 comment · May be fixed by #114
Assignees
Labels
enhancement New feature or request v3

Comments

@mo-esmp
Copy link
Member

mo-esmp commented Aug 23, 2023

Hence, reading log data from log data providers is dependent on log table schema; we should insert log data through sinks and not directly into the database. @followynne What do you think of this?

@mo-esmp mo-esmp added the enhancement New feature or request label Aug 23, 2023
@followynne
Copy link
Member

Hello @mo-esmp

I agree 100% with you, the issue I found on this topic was inserting data in a "managed" way to be able to test some filters...
The filter that's difficult to test with this approach would be the time range one - I don't think the ILogger interface let us insert logs with a certain timestamp.

On Elastic Search I used the serilog-sink approach, if you want to check 😄

@followynne followynne linked a pull request Mar 18, 2024 that will close this issue
@followynne followynne linked a pull request Mar 20, 2024 that will close this issue
@followynne followynne added the v3 label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants