-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing seconds #69
Comments
Uhm, that's a good point! I think we could make the search input more precise in the UI - we can think of doing this fix in the new repo 😊 Actually, I was thinking about transforming the JS app into a React-based one, for fun... Do you think it would be something interesting/useful/you'd like? We could revamp the UI by replacing Bootstrap with another design system style 😂🥸 |
I do like to change the whole UI and there is an issue related to it. The next move for this project would be adding analytics and for sure we need better UI. |
Okay, we can try to improve it - if we're okay with moving to React, I can take charge of the current UI migration/refactor and start doing it as soon as we're on the new repo 💯 I would only need a couple of things:
If you confirm me about React, I'd proceed with this todo:
Let me know 😉 |
|
Awesome, thanks! On the design systems, I'll take a look around and propose some options, based on the React components they provide out of the box 🤗 |
What is your idea about Blazor? should we consider it as an option? |
That's a good point - Blazor vs React is a topic I considered too many times 🤣 IMHO, those could be the key points to choose between them:
At the end, if I were to choose, I'd go with React because
but it's really a matter of preferences, at the end :D |
Fair enough, let's go with React! |
I was trying to reproduce issue issue 96 and figure out that the time is shown wrongly. My time zone is GMT+1, and that's why there is a one-hour difference. Hence, we don't know how the actual sink saves time in UTC or local time; let's not convert to local time. I checked the code and found out the export const formatDate = (date: string) =>
format(parseJSON(date), 'PP H:mm:ss.SSS', { weekStartsOn: 1 }); |
I think you're right, I need to check back the original formatting function - if I recall correctly, I did port it as it was originally. There could also be some relation with packages upgrade, I'll try to understand what changed between the 2 providers versions... EDIT: probably it's the PP of date-fns, I'll check if I can improve the parsing format 😅 |
Not a big deal, however, may cause some logs to be missed. @followynne better to handle in UI or in Code?
The text was updated successfully, but these errors were encountered: