Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy in the Examples #25

Open
adriansergheev opened this issue May 4, 2020 · 8 comments
Open

Discrepancy in the Examples #25

adriansergheev opened this issue May 4, 2020 · 8 comments

Comments

@adriansergheev
Copy link

In the lib itself, the Reducer<State, Event> is a typealias, like so:
public typealias Reducer<State, Event> = (inout State, Event) -> Void
In the Examples however, they use a struct, with an init, like so:

` public let reduce: (inout State, Event) -> Void

public init(reduce: @escaping (inout State, Event) -> Void) {
    self.reduce = reduce
} etc...`

Where is the truth? :)

Thanks for the work on the library!

@sergdort
Copy link
Owner

Hey, it may be a mistake or a typo on my side the reducer now is a struct, I took this idea from Pointfree composable architecture
https://github.com/sergdort/CombineFeedback/blob/master/Sources/CombineFeedback/Reducer.swift#L3

@VNadygin
Copy link

@sergdort I found the same issue. Then you install the library from Swift Package manager you have a different Reducer implementation. I would be so nice if you can update the package

@maximkrouk
Copy link

@VNadygin For now you can use .package(url: "git@github.com/sergdort/CombineFeedback.git", .branch("master"))

Btw today I figured out, that there is no example with navigating back programmatically 😢 (And I don't know yet how to handle it, yet, so maybe it's not too late to send feedback before I figure it out by myself 😎)

@NSMyself
Copy link

NSMyself commented Aug 10, 2020

I'm seeing the same thing happening but regarding feedbacks. Pointing to master solved it, thanks @maximkrouk and @VNadygin

@sergdort
Copy link
Owner

Do I need to publish new version 🤔

@sergdort
Copy link
Owner

Also guys I'm a lacking free time lately. So if someone would like to be a maintainer I would love to create an org and move project there

@NSMyself
Copy link

@sergdort I don't have much nowadays but I'd gladly help out on what i can.

@maximkrouk
Copy link

I have migrated to the composable architecture btw 👽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants