Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Searching test results should match on the steps #3438

Open
1 of 3 tasks
jfstephe opened this issue Apr 12, 2024 · 6 comments
Open
1 of 3 tasks

Feature Request: Searching test results should match on the steps #3438

jfstephe opened this issue Apr 12, 2024 · 6 comments

Comments

@jfstephe
Copy link
Contributor

jfstephe commented Apr 12, 2024

What's the Problem You're Trying to Solve?

Team members want to filter the features by the steps/data and not just the feature/scenario description. This is not possible in the current offering.

Proposed Solution

The test steps are already available in the cucumber test results and in the Serenity BDD Reporter, this "just" needs to be included as terms to search on, in the filter.

Happy to make a PR if you point me where to go.

Alternative Solutions

N/A

Implementation Support

  • Contribute the feature myself (with guidance from the Serenity BDD team)
  • Hire the Serenity BDD team for implementation
  • Add it to the Serenity BDD backlog and wait for community contribution
@wakaleo
Copy link
Member

wakaleo commented Apr 15, 2024

I would welcome a PR to do this. Have a look at the freemarker template files for these reports (the filtering uses a Javascript library if I recall correctly so should be relatively straightforward to extend).

@jfstephe
Copy link
Contributor Author

Thanks @wakaleo. I'm looking around it now and I think I'm getting somewhere with the code but I can't get it to build.

I'm using VSC and it fails with:

> Task :serenity-model:compileJava FAILED

FAILURE: Build failed with an exception

Screenshot:

image

Versions of everything I can think of that may be relevant:

Ubuntu:
20.04
Java:
openjdk 11.0.22 2024-01-16
OpenJDK Runtime Environment (build 11.0.22+7-post-Ubuntu-0ubuntu220.04.1)
OpenJDK 64-Bit Server VM (build 11.0.22+7-post-Ubuntu-0ubuntu220.04.1, mixed mode, sharing)
mvn:
Apache Maven 3.6.3
Kotlin:
v1.9.23

I followed the CONTRIBUTING.md but I feel like I'm missing something obvious (it's been a while since I've done any java). When I run "mvn clean install" in the serenity-model folder it works, but wgradle doesn't like it.

Any ideas?

@jfstephe
Copy link
Contributor Author

Thinking about it, could it be that I'm not using intelliJ?

@jfstephe
Copy link
Contributor Author

Spent an hour trying to add in the missing gradle dependencies and it's killing me a little. Can improvements be made to document the expected development environment when contributing? I'm falling ATM but it's not a pit of success...

@wakaleo
Copy link
Member

wakaleo commented Apr 18, 2024

The Serenity build uses Maven, we dropped Gradle a while back when JCenter was shut down

@jfstephe
Copy link
Contributor Author

@wakaleo - then the CONTRIBUTING.md really needs updating as it's talking about wgradle and there's all the gradle files still around :-(

@jfstephe jfstephe changed the title Feature Request: Searching test results doesn't match on the steps Feature Request: Searching test results should match on the steps Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants