Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When on typescript project, sequelize-cli still generates javascript files. #1436

Open
1 task done
malik-samad opened this issue Dec 25, 2023 · 3 comments
Open
1 task done

Comments

@malik-samad
Copy link

malik-samad commented Dec 25, 2023

What I am doing?

I'm using Sequelize-cli in a typescript project and it is not generating .ts files and I have to then update those files extensions and make manual changes to the file for making it compatible in my project.

What I expect to happen?

I want to have the CLI work the same for my typescript file as it does for a javascript project. I expect the cli to generate proper migration, see and model files with .ts extension.

What is actually happening?

When I try to run sequelize init or other migration cli, it will generate javascript files instead of typescript as expected.

Dialect: mysql
Database version: latest
Sequelize CLI version: latest
Sequelize version: latest

Would you resolve this issue by submitting a Pull Request?

  • Yes, I have the time and I know how to start.

I have completed and fully tested the configuration and changes needed for this issue fix, but I am not able to push my work into the repository. Could you please help me get access so that I can push my work on this issue?

@WikiRik
Copy link
Member

WikiRik commented Dec 25, 2023

Thanks for opening this! You can fork this repository, push the changes to there and then open a pull request here

@berubenic
Copy link

+1

@malik-samad
Copy link
Author

Hi WikiRik,
I have opened a PR for this issue and it needs your review. please have a look and help me get in making it merged into package.

The PR has 1 regex change which is reported by CodeQL and it needs approving from reviewer as I think its a false positive.

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants