Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"make test" always uses the last successfully build binary although building failed #22

Open
1 task
smehringer opened this issue Sep 29, 2020 · 3 comments

Comments

@smehringer
Copy link
Member

smehringer commented Sep 29, 2020

This can lead to 100% tests passed although one of the tests failed to build and should thereby also fail the test (not run).

Acceptance Criteria

  • If a test fails to build the test should not pass when running make test
@marehr
Copy link
Member

marehr commented Sep 29, 2020

This is standard behaviour of cmake. We can't change that?!

EDIT:// I forgot that we added non-standard behaviour that make test builds the tests.

@smehringer
Copy link
Member Author

smehringer commented Sep 29, 2020

This is standard behaviour of cmake. We can't change that?!

When I mentioned that in Gitter you said Write that down :) 🤷 So I thought it's worth an issue.
If we won't change this anyway I can clode the issue again.

@joergi-w
Copy link
Member

I currently see 3 solutions:

  1. Automatically perform a make clean before each make test build – disadvantage: unnecessarily long build time.
  2. Implement standard behaviour and build tests with make – disadvantage: much refactoring.
  3. Actively delete the respective existing binary file when a build fails – disadvantage: even more non-standard code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants