New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incremental scan does not add new tracks #63
Comments
ok having a look now. it seems for some reason the cleaning logic is deleting tracks it already added just before? |
good news, I can reproduce it |
Awesome! Is it related to the cleaning step? |
hi! can you try |
Hello, It does not seem like you've pushed the branch you specified, at least I can't see it among the remote branches. |
The branch is https://github.com/sentriz/gonic/tree/scan-clean-del And the image the most recently updated https://hub.docker.com/r/sentriz/gonic/tags |
Ah, thanks. It seems that we have the same issue as before. Starting at 83004 via an incremental scan:
The web interface shows that we have 83004 tracks still. |
hmm that is strange indeed. also can't understand why your times are so slow. you only have less than 3x the tracks I have but mine are like
is your db file running on a spinning disk? as for the 19 errors you're getting. can I email you about this? |
Ah, I wouldn't worry about the scanning speed. I'm running Gonic on a Raspberry Pi 3 and the DB is indeed on a spinning disk. On top of that, I am running "flac -t" on a bunch of lossless files at the moment, so that's also a huge setback. It's a lot faster in a normal case. Sure, feel free to drop me a mail and we can discuss specifics. They are mainly tag read errors for a few m4a/m4b/flac files. |
hey I just saw your matrix |
hey I think this may be fixed now after some scanner stuff that changed a few months ago, but let me know if not 👍 |
Hi @sentriz , I've been silently following this issue these last months as I began using Gonic around 1 year ago and have been seeing the same problems on my music folders. You are partly right, I have been seeing some very appreciated progress on these few music files which weren't available through Gonic until now. However, my instance seems to never stop rescanning my files, when no new file has changed. This prevents the user from playing songs on a player (I mainly use jamstash) since they may be temporarly removed, and probably adds a good load on the processor all day long. I do understand that this may happen because of bad music files or idk, but it is quite difficult to know which ones. Thanks again for your work, this is awesome :). |
hey @Cherryblue @ygbillet would you mind sending me a handful of audio files that aren't being scanned properly? and perhaps the file structure that they're in. |
Hello, After my last post I used the tool "mp3val" to go and repair/clean my files, and now have 0 file with error. @sentriz does gonic try to fix any file itself ? My setup uses a read-only music folder which I share from my personal seafile (a self hosted dropbox alternative). Apart from that, I can't seem to understand why the software would loop the scan this quick. |
@Cherryblue I also only give gonic read only access to my audio so there shouldn't be issue there I think btw when you a scan again (not full scan), do you still get that "169 removed" artists? |
@sentriz OK, RO isn't the issue then ! When refreshing the UI portal, I can see the number of tracks increasing, this should correspond to the +322 tracks being removed and readded again and again. But I have no idea how to identify which files have the problem in the collection :( |
ah! sorry then I mis-read your message about the loops! that is very strange indeed presuming you are using env vars to configure configure gonic docker compose, what do you have GONIC_SCAN_INTERVAL set to? |
I use Here is my complete docker-compose : |
@sentriz i remove my comment after i re-read the readme. I will evaluate the feasibility of changing the organization of the files and directories in order to use Gonic ! In any case it is a great product according to my requirements (small footprint, fast, easy to deploy, simple to use). |
@ygbillet @Cherryblue |
I just made a debug build when it's done the image should be at sentriz/gonic:issue-63 could you try it when it builds please? |
@sentriz hey, I just sent you the logs by e-mail. Following ygbillet post, I should tell you I have a few folders with multiple albums or artists in it, but it only represents something like 5% of my collection and I do understand that it is not supported. I prefer to tell you in case it's linked to the behavior we see on my end. Still, from my understanding :
Thanks again for your help, have a great day |
Hmm, I never had this issue on my library, but there was another thing (that I'm kinda reluctant to reproduce at the moment, but will try a bit later after I file my other PRs): In In one case I moved one of albums in my library to another directory (found a typo in album name and fixed it), and it caused ALL tracks to change their IDs and messed up my playlist. :D |
this way, if the average scan takes longer than the tick interval, the ticker will be unblocked and scans won't stack on top of each other related #63
should be fixed now! thanks for all your help |
I currently have a Gonic database with 83007 tracks. After Gonic finishes running an incremental scan, I get:
The errors are related to tag reading from a few flac and m4a files.
After this, I see the new number of tracks as 83734 via the web interface, which is correct. Then, cleanup runs, and I get:
Right after this, the number of tracks reverts to 83007 tracks again.
What is interesting is that even if I run a full scan, Gonic does not seem to pick up all the tracks.
The text was updated successfully, but these errors were encountered: