New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple libraries #50
Comments
hey thank you :) what I've been doing is making a |
Hi, Sentriz. Amazing project. It would be nice assign libraries to user, and isolate the mp3 tree structure for each user. Thanks! |
👍 My use case is having folders/libraries for different types of audio (e.g. audiobooks, podcasts and music). Lumping these together, especially if your library is large, makes browsing specific types rather awkward. I think this is the only feature I still miss from *sonic. I'd be willing to chip in on a bug/feature bounty if anyone wants to set it up :) |
Thanks for this project Sentriz!! I would love to see this implemented too. |
I don't really see a problem with this approach. Can someone explain why they wouldn't want to do this? I think an implementation would have the similar effect, so I'm not unaware of the (potential) benefits.
I think this would be the only benefit. Are there others? |
What I said above:
I said "awkward" previously but in reality it's near impossible. |
This is because you're envisioning these multiple folders getting read in would be in different views? |
Ahh, right. Gotcha. Okay, seems interesting enough. Thanks for all the information. |
thanks too @djl this makes sense to me after seeing that screenshot I've never even seen the ability to change music folders in the subsonic clients I use but that seems handy |
My use case is similar to @djl but with genres. For example, in Play:sub iphone client you can select the folder. I have my library organized by genre and I usually start a random playlist within that genre: Trying to do the same but using the genre tags becomes quite a challenge. I have something like a thousand different tags... |
There is also the issue of accessing symlinked paths on the host when you run gonic in docker. You can work around it by also mounting the paths that the symlinks point to, but it sort of defeats the point of symlinks, having to manage potentially many folders. Whilst I don't divide my collection up in genre folders, I do have different folders like "new" (albums I just bought, but haven't listened a lot to yet), and albums then get moved to "unsorted" (the ones I liked and deemed were worth keeping), then I spend some time prettying up the folders/files/cover art/info and ultimately move them to "archive". Occasionally I may want to filter on that in my player. |
hi all, I added some experimental support for this. if anyone is familiar with building from source and would like to test it, checkout the
then multiple paths can be added by repeating the flag. eg $ gonic \
-music-path /example/path/a \
-music-path /example/path/b \
-music-path /example/path/c or if you're using env vars, try if you want to speed up the gonic scan after adding multiple folders for the first time, provide your original (non extra) music dir as the first argument. |
@cascooscuro thanks for trying it out :) could you post the logs around the time of the iSub request to getMusicFolders? just interested in the query params that it's sending also if you can, post the response from the request it is making? just a simple curl of the url it's requesting or put the url in your browser |
this is the tcpdump for iSub (
In this case iSub is only displaying "opera". It looks that it only sees the last musicfolder... These are the logs for play:Sub app (
And finally for DSub (
|
@cascooscuro thank you kindly. very detailed :) I think the issue is that iSub expects the music_folder ID to be an int (true to the spec) where as other clients allow strings. let me see if I can make them ints |
@cascooscuro how does the |
It works!!! iSub now correctly displays all the music folders. Play:Sub and DSub keep working too. Thanks for fixing it so quickly! |
* make `musicFolderId`s ints #50 (comment) https://github.com/einsteinx2/iSubMusicStreamer/blob/006c1dafee6b926fde9d775cb0e64011a4662853/Classes/Models/API%20Models/MediaFolder.swift#L16 related #50 * add a test for multi folders and reused artists
great to hear :) gonna merge that branch to master then. though not gonna release for a while because i still think it's a bit experimental. thanks for your help and let me know if something weird happens 👍 |
Thanks for this great project !
But a major feature of Airsonic is missing, be able to have multiple libraries.
The text was updated successfully, but these errors were encountered: