Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Include genre and album's date/year in listenbrainz scrobble payload #468

Open
TomboFry opened this issue Feb 11, 2024 · 3 comments

Comments

@TomboFry
Copy link

Hello! I've been an avid user of Gonic for a few years now, and I'd really like for it to provide some additional fields when scrobbling to Listenbrainz. Specifically:

I'm not 100% sure about including the second field, as I've not seen it referenced anywhere in the official ListenBrainz API docs, especially in the table linked above, nor could I really find much else online (however in a very niche use-case it is something a sample of a foobar extension sends within its payload, which I've accidentally been fully embracing long before looking up the details to raise this issue). In any case, I'd be happy to exclude this one for the sake of fitting to the spec.

I believe these should be relatively easy implementations after having read listenbrainz.go, and have absolutely considered making the contributions myself but am not at all used to the Go language and have struggled setting up the development environment to test it properly in the past 😅.

@sentriz
Copy link
Owner

sentriz commented Feb 11, 2024

hm I think this would need to be configurable. for example I use lastfm for tag genre metadata which quite often can be completely wrong (eg two artists with the same name)

I think it would be irresponsible for me for example to just start submitting those tags (some of which genres) to MB

where do you get your genre metadata as a matter of interest ? 👀

@TomboFry
Copy link
Author

TomboFry commented Feb 11, 2024

I use lastfm for tag genre metadata which quite often can be completely wrong

That's fair! I'm not sure how seriously the field should be taken, considering the ListenBrainz documentation provides all metadata and MB UUIDs fields accurately for Never Gonna Give You Up, yet suggests [ "you", "just", "got", "rick rolled!" ] for the tags field 🤔 It also suggests the field is "A list of user-defined folksonomy tags to be associated with this recording"

where do you get your genre metadata as a matter of interest ? 👀

Mostly manual - either from knowledge about the artist, and I'll use pretty consistent naming across my library, or from Wikipedia or MusicBrainz itself.

@sentriz
Copy link
Owner

sentriz commented Feb 11, 2024

yeah you can have nonsense tags like that fine, but if any of them happen to be also part of the list of predefined genres, then it comes a genre

https://musicbrainz.org/tags

but yeah sure if people like yourself are manually adding genre info to your metatdat then this definitely makes sense. just the automatic sending of unverified potential genre tags to mb could hurt the data I reckon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants