Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: try all tracks in dir for album metadata instead of first #462

Open
s-fleck opened this issue Jan 25, 2024 · 0 comments
Open

feat: try all tracks in dir for album metadata instead of first #462

s-fleck opened this issue Jan 25, 2024 · 0 comments

Comments

@s-fleck
Copy link

s-fleck commented Jan 25, 2024

I've raised these before on the chat, and understand that it's intended behavior. I just wanted to try one more time argue my case because it is a recurring source of annoyance for me, but if you mark it as wontfix I promise to not bug you again.

Behavior: Some audio files with sketchy headers will abort the scan of a directory and the whole directory will not be available in gonic. All this happens silently in the background.

Why this is a problem for me specifically

  • I have some music ripped from youtube with a tool that extracts the original stream without re-encoding
  • I'm talking about music originally released on youtube and not available from any other sources that i want to preserve for archival purposes (live recordings, meme music, etc...)
  • Some ogg files are missing the stream header. There is no way to reconstruct these header without (lossy) re-encoding according to my research
  • All these files play fine in all common music players. I can live with these files not showing up in gonic, but them breaking the whole folder is annoying.

Other reasons to argue my case

  • Somewhat surprising behavior and therefore hard to debug
  • Makes it hard to figure out which files actually cause the problem

Proposed solution:
Rather than discarding the whole album, just discard the track.

edit: clarified details

@sentriz sentriz changed the title Gonic not scanning folder if encountering file with "sketchy" header feat: try all tracks in dir for album metadata instead of first Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants