Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix listenbrainz track length submission and include submission client details #424

Merged
merged 3 commits into from Dec 10, 2023

Conversation

phw
Copy link
Contributor

@phw phw commented Dec 10, 2023

This fixes the track length submission for ListenBrainz. ListenBrainz defines the fields duration and duration_ms for this, see https://listenbrainz.readthedocs.io/en/latest/users/json.html . Without this information LB will not show a track length. It might also prematurely remove the "now playing" notification for longer tracks.

As I understand from the code the track length is in seconds precision, hence the duration field is being used. duration_ms would be for milliseconds.

This PR also includes the fields submission_client as defined in the LB API docs linked above.

@sentriz sentriz merged commit b27c02f into sentriz:master Dec 10, 2023
1 check passed
@sentriz
Copy link
Owner

sentriz commented Dec 10, 2023

thanks!

@phw phw deleted the fix-listenbrainz branch December 10, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants