Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support getAlbumList2 type=highest #404

Closed
GioF71 opened this issue Nov 6, 2023 · 4 comments
Closed

support getAlbumList2 type=highest #404

GioF71 opened this issue Nov 6, 2023 · 4 comments

Comments

@GioF71
Copy link

GioF71 commented Nov 6, 2023

Hello, thank you for your great software.

I am maintaining a subsonic client for upmpdcli: see here a slightly outdated changelog.
I started with navidrome, and only recently I tried to update my work so that it could support Gonic as well.
I have a small issue with the album title missing (available in 'name' however), which is a different behavior compared to navidrome, but no big issue there, I could work around this issue easily.

On the other hand I noticed that, while Navidrome supports "highest" as list type in the getAlbumList2 api method, Gonic doesn't seem to.
I understand that, looking at the api documentation, that value should not be supported anyway, but considering that Navidrome supports it, is there a chance that Gonic can implement it?

Thank you for any feedback, all the best.

@sentriz
Copy link
Owner

sentriz commented Nov 6, 2023

oh i see. i'm not sure when highest became a thing, but yes it does seem to be part of @opensubsonic now. so sure i can add it 👍

https://opensubsonic.netlify.app/docs/endpoints/getalbumlist2/

@sentriz sentriz changed the title [Question] Support for 'highest' (highest rated albums) in getAlbumList2 support getAlbumList2 type=highest Nov 6, 2023
@GioF71
Copy link
Author

GioF71 commented Nov 6, 2023

Awesome! Thank you!

sentriz added a commit that referenced this issue Nov 8, 2023
@sentriz sentriz closed this as completed in a30ee3d Nov 8, 2023
@sentriz
Copy link
Owner

sentriz commented Nov 8, 2023

i added support for getAlbumList?type=highest and getAlbumList2?type=highest

also filled in the "album", "title" and "name" fields for subsonic albums in tags/folder modes 👍

@GioF71
Copy link
Author

GioF71 commented Nov 9, 2023

That worked perfectly! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants