Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Gonic can't locate cover/folder.jpg in a folder, use the first image from that folder instead #338

Open
awsms opened this issue Jun 29, 2023 · 9 comments

Comments

@awsms
Copy link

awsms commented Jun 29, 2023

Title sums it all!

@sentriz
Copy link
Owner

sentriz commented Jun 29, 2023

not sure its a great idea. I don't like unexpected behavior personally. are there any filenames you would like to add to the list of acceptable cover art filenames?

@sentriz sentriz closed this as completed Jun 29, 2023
@awsms
Copy link
Author

awsms commented Jun 30, 2023

There are a bunch of known templates,
"Albumname.jpg" or "Artist - Albumname.jpg" for EAC rips,
"R-digits-digits.jp(e)g" for discogs,
"00-.*.jpg" for scene releases

I reach the point where a third of my music collection doesn't have an artwork image because of this

@sentriz
Copy link
Owner

sentriz commented Jun 30, 2023

good point 👍

@awsms
Copy link
Author

awsms commented Jul 19, 2023

On a related note, what do you think about parsing (the first track of a folder's) attached images in the tags?
In case Gonic couldn't find a cover image in the folder of course.

@sentriz
Copy link
Owner

sentriz commented Jul 19, 2023

there's an issue tracking that one #11

@gerroon
Copy link

gerroon commented Nov 13, 2023

Can Gonic grab cover images from the songs as well? It would be nice if it can't find a album image in the folder, it just grabs from the first song that has embedded image.

@sentriz
Copy link
Owner

sentriz commented Nov 13, 2023

there's an issue tracking that one #11

@s-fleck
Copy link

s-fleck commented Dec 16, 2023

Just wanted to +1 this. I know unexpected behavior is something that's not a comfortable idea from a programmers perspective... however.:

  • i'm pretty sure it's possible to come up with heuristics that display the "best" cover in 99% of the cases
  • even if the wrong image is displayed, that's probably still nicer from an UX perspective then none at all! It still gives you a visual clue.

I prioritizing the following regex patterns (in that order) would already work pretty well:

  1. folder.*
  2. cover.*
  3. front.*
  4. .*cover.*
  5. .*front.*
  6. 00.*
  7. .*scan.*
  8. any image file

if there are several matches for one pattern, always take the first one (sorted alphabetically).

This does not account for:

  • Subfolders (Artwork, Covers, Scans) - probably a bit more complicated i assume?
  • Images from the tags (not sure if they are supported, if not they should probably have pretty high priority? just under folder.*?)

@awsms
Copy link
Author

awsms commented Apr 15, 2024

Is there any interest from the dev to implement this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants