Update linter #325
Merged
Update linter #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gzurowski
commented
May 19, 2023
gzurowski
commented
- Update Github golangci-lint-action to v3.
- Update golangci-lint to v1.52.2.
- Fix all linter issues (remove/_ unused arguments, stop using reserved keywords).
- Update Github golangci-lint-action to v3 - Update golangci-lint to v1.52.2
sentriz
reviewed
May 19, 2023
| with: | ||
| version: v1.50.1 | ||
| skip-go-installation: true | ||
| version: v1.52.2 |
There was a problem hiding this comment.
why do we get rid if skip-go-installation? iirc it was true because we have the setup go action above
There was a problem hiding this comment.
The option has been removed in the new version of golangci-lint-action, see: https://github.com/golangci/golangci-lint-action#compatibility:
v3.0.0+ requires explicit setup-go installation step prior to using this action: uses: actions/setup-go@v3. The skip-go-installation option has been removed.
|
cool thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.