Podcast episode w/o audio causes segfault

[brian-doherty]

2022/12/09 11:41:27 failed to find audio in feed item, skipping
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0xc8 pc=0x8e3872]

goroutine 50133 [running]:
go.senan.xyz/gonic/podcasts.(*Podcasts).AddNewEpisodes(0xc0002c2e10, 0xc0003906c0, {0xc000bae800?, 0xc7, 0x100})
/home/brian/gonic/podcasts/podcasts.go:173 +0x212
go.senan.xyz/gonic/podcasts.(*Podcasts).refreshPodcasts(0xc0001c1e10?, {0xc0000bc1c0, 0x7, 0x0?})
/home/brian/gonic/podcasts/podcasts.go:301 +0x2df
go.senan.xyz/gonic/podcasts.(*Podcasts).RefreshPodcasts(0xc0002c2e10)
/home/brian/gonic/podcasts/podcasts.go:286 +0xdd
go.senan.xyz/gonic/server.(*Server).StartPodcastRefresher.func1()
/home/brian/gonic/server/server.go:398 +0x98
go.senan.xyz/gonic/server.(*Server).StartPodcastRefresher.func2()
/home/brian/gonic/server/server.go:406 +0x43
github.com/oklog/run.(*Group).Run.func1({0xc000442f00?, 0xc0002a8048?})
/home/brian/go/pkg/mod/github.com/oklog/run@v1.1.0/group.go:38 +0x2f
created by github.com/oklog/run.(*Group).Run
/home/brian/go/pkg/mod/github.com/oklog/run@v1.1.0/group.go:37 +0x22a

AddEpisode returned nil, nil in this case which shouldn't be hit. Recommend it return an error of your choice instead so that the caller doesn't assume the episode returned is non nil.

[sentriz]

thanks, how does this look? b47c880

[brian-doherty]

Looks great, thanks!

…

On Mon, Dec 12, 2022 at 12:31 PM Senan Kelly ***@***.***> wrote: thanks, how does this look? b47c880 <b47c880> — Reply to this email directly, view it on GitHub <#269 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASFD42LAFWPT3ETV4R3Q4S3WM5VRDANCNFSM6AAAAAASZU3WTM> . You are receiving this because you authored the thread.Message ID: ***@***.***>