New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Flexible transcode #241
Comments
hi, this was changed recently . what version of gonic are you on? and from source or docker? |
PS can you show me the stream.view line in the gonic logs when dsub requests unlimited bitrate? |
log:
version: sentriz/gonic:nightly I am on WiFi when I triggered the above log. So the setting should be unlimited. |
The original flac file should be > 20MB and in flac format |
More detailed log:
|
thanks, i think it should be fixed now |
nightly is building currently. progress is here https://github.com/sentriz/gonic/actions/runs/3101783823 let me know how it goes 👍 |
I still has issue:
|
"Opus at 128 KB/s (VBR) is pretty much transparent" https://wiki.xiph.org/Opus_Recommended_Settings related #241
that's expected. the gonic profile you selected is a 96kpbs profile. the maxbitrate greater than that so you get 96. if you use a 128 kpbs profile then and a matching maxbitrate it should work. i just pushed a commit to add that to the settings 👍 https://wiki.xiph.org/Opus_Recommended_Settings |
But:
On DSub, it also shows 96kbps. Thanks for your help and responses! |
"Opus at 128 KB/s (VBR) is pretty much transparent" https://wiki.xiph.org/Opus_Recommended_Settings related #241
sorry, silly mistake on my part 😁 new build https://github.com/sentriz/gonic/actions/runs/3104973311 |
Great, it works as expected now! |
This is related to #121 and #91
On clients such as DSub, the transcode setting allow user to specify different maximum bitrate under WiFi and cell data.
I set DSub using opus transcode profile under gonic.
I set maximum bitrate under WiFi as "Unlimited"
I set maximum bitrate under Cell Data as "196Kbps"
I played a flac format track with bitrate around 600Kbps
Expected behavior:
Under WiFi, the track should be played as original flac file without transcoding since "Unlimited" > 600Kbps.
Because "Unlimited" > 600Kbps, it will not trigger transcoding. File will be served as it is.
Under Cell data, transcode will be triggered and will be streamed as a 196Kbps opus format.
Actual behavior:
Under both WiFi and Cell, regardless of maximum bitrate setting, file will be streamed as 96 Kbps opus.
The text was updated successfully, but these errors were encountered: