Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar support #228

Closed
wants to merge 21 commits into from
Closed

Avatar support #228

wants to merge 21 commits into from

Conversation

brian-doherty
Copy link
Contributor

No description provided.

@sentriz
Copy link
Owner

sentriz commented Jun 27, 2022

at a first glace, looks great :) thank you kindly 👍

could we merge "change avatar" and "delete avatar" into just "change avatar"? then have a delete button on the change screen. would be nice i think

image

also for the style of "choose file"
image

could we make it match the other upload button for playlists?

image

if i remember right it does some magic with a hidden element so we can have custom style

@brian-doherty
Copy link
Contributor Author

See what you think. I made delete red as a warning but of course that's easy to change.

@brian-doherty
Copy link
Contributor Author

Hey, so what do you think of my changes?

@sentriz
Copy link
Owner

sentriz commented Jul 13, 2022

howdy! thanks very much for the changes . haven't had a chance to look yet but will shortly 👌

@sentriz sentriz closed this in 5e66261 Jul 20, 2022
@sentriz
Copy link
Owner

sentriz commented Jul 20, 2022

hiya brian! sorry it took so long to get back to you. not much free time recently and didn't have time for a full review

but this looks really nice now, thanks very much 👍 👍

made some small changes, hope it's ok. let me know if not

  • got rid of the inline <script />s this has casused issues with CSP in the past (unsafe-inline IIRC, not sure though) instead I just made the upload functionality the same as the playlist upload, using the external script file
  • this also means the style of the upload button is the same (incl mouse over etc)
  • some go styling stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants