Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return genre and year tag in getMusicDirectory Child elements #223

Closed
thirtythreeforty opened this issue May 17, 2022 · 1 comment
Closed
Milestone

Comments

@thirtythreeforty
Copy link
Contributor

The Subsonic API allows optional genre and year fields in <Child> tags. Can these be added to the response?

trCh := &TrackChild{
ID: t.SID(),
ContentType: t.MIME(),
Suffix: t.Ext(),
Size: t.Size,
Artist: t.TagTrackArtist,
Title: t.TagTitle,
TrackNumber: t.TagTrackNumber,
DiscNumber: t.TagDiscNumber,
Path: path.Join(
parent.LeftPath,
parent.RightPath,
t.Filename,
),
ParentID: parent.SID(),
Duration: t.Length,
Bitrate: t.Bitrate,
IsDir: false,
Type: "music",
CreatedAt: t.CreatedAt,
}

Clients might cache this and use it, rather than browsing by the dedicated genre API. (I'm writing such a client for Poweramp and all tracks show up as "unknown genre.")

@sentriz
Copy link
Owner

sentriz commented May 18, 2022

thanks makes sense

@sentriz sentriz added this to the next release milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants