Added error case for when DownloadEpisode is called via API and podcast is already downloaded #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Senan Kelly <senan@senan.xyz>
…st is already downloaded.
|
@lxea thoughts on this one |
|
This seems fine to me, sometimes it can be useful to redownload stuff when a response is an error page which was happening to me with some feed hosts, but i havent come across that in a while + it should probably just be handled properly by trying to parse the mp3 or checking the staus code or something |
|
FYI without this fix I was getting multiple copies of the same podcast with different filenames:
|
sentriz
added a commit
that referenced
this pull request
Apr 20, 2022
…onnection is TLS closes: #213 Co-authored-by: Brian Doherty <brian.r.doherty@gmail.com>
|
thanks 👍 squashed and added @lxea does this mean that we don't need the rename |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.