Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API lookup albumList byYear with range error #208

Closed
robot3498712 opened this issue Mar 30, 2022 · 1 comment
Closed

API lookup albumList byYear with range error #208

robot3498712 opened this issue Mar 30, 2022 · 1 comment

Comments

@robot3498712
Copy link

robot3498712 commented Mar 30, 2022

Hi, I may have found an issue:

https://github.com/sentriz/gonic/blob/release-v0.15.0/server/ctrlsubsonic/handlers_by_folder.go
(and possibly other handlers)

"tag_year BETWEEN ? AND ?",
			params.GetOrInt("toYear", 2200),
			params.GetOrInt("fromYear", 1800))

Params are in incorrect order; fromYear should come first.
Noticed via https://github.com/crustymonkey/py-sonic/blob/master/libsonic/connection.py

@sentriz sentriz closed this as completed in d7655cb Apr 2, 2022
@sentriz
Copy link
Owner

sentriz commented Apr 2, 2022

thanks. that was silly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants