Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how subsonic ServceGatArtistInfoTwo is retrieving similar artist #203

Merged
merged 1 commit into from Feb 25, 2022

Conversation

xaviercrochet
Copy link
Contributor

Hey there

I made the following improvement to /getArtistInfo2

I realized that, as lastfm.artist.getInfo as only retrieving a couple of artist, /getArtistInfo2 was most of the time returning very few (or no) similar artists.

  • Retrieve similar artists using ```lastfm.artist.getSimilar``
  • Match similar artists result with internal database in one single sql query, using a similar pattern as we used for ServeGetSimilarSongs and ServeGetSimilarSongsTwo

@sentriz sentriz merged commit e877adc into sentriz:master Feb 25, 2022
@sentriz
Copy link
Owner

sentriz commented Feb 25, 2022

cool thanks!

sentriz pushed a commit that referenced this pull request Feb 25, 2022
sentriz pushed a commit that referenced this pull request Feb 25, 2022
@sentriz
Copy link
Owner

sentriz commented Feb 25, 2022

actually I just realised that with this change we never return any artists that aren't in the database (not respecting the includeNotPresent param) so I adjusted the commit to be a bit more similar to how it was, just using the lastfm.ArtistGetSimilar

does that seem ok to you?

image

@xaviercrochet
Copy link
Contributor Author

Yes this will do the trick, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants