Feat/get similar songs 2, Feat/get similar songs, Feat/get top songs

[xaviercrochet]

Implementation of subsonic getSimilarSongs2 and Last.fm artist.getSimilar

N.B. I inspired myself of ampache 's implementation src/Module/Api/Subsonic_Api.php:2229 as Last.Fm doesn't expose such endpoint.

The logic is the following:

1. Retrieve artist 's similar artists using Last.fm 's artist.getSimilar
2. Look in our database for tracks matching the similar artists
3. Randomize (then trim) the track set to prevent ending up with X track of the same artist.

What do you think about this approach?

[sentriz]

hi! these are looking great. though it seems this pr 3 contains pr 2, and pr 2 contains pr 1

perhaps for each of your 3 branches you should rebase them on master

[sentriz]

just had a look and I had a few minor comments. mostly around formatting and I think some stuff wasn't needed

how do you feel about these changes?
99c2022

to summarise

• shuffing the results at the database level instead of application, using the clause LIMIT clause based on the size param. I think this should not have adjacent tracks by the same artist like you mention
• updating the lastfm API helper functions to not depend on the db package
• moving the spec struct variables to the bottom of the handlers

how does it sound to you? does it work still? I tested a bit and it seems to

thank you kindly!

[xaviercrochet]

Sounds good, thanks!

[xaviercrochet]

Done!

[sentriz]

hey I split the changes into 3 commits, one for each new view, and added you as the author. this way it shows up nicely in the changelog for the next release

#160

let me know if all is working well still. thanks very much!

[xaviercrochet]

Thank you @sentriz.

Have a nice one!