Strip EBU R128 gain tags when using forced-RG transcoding #145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @sentriz, long time no see! :)
I was messing around with my encode profiles and found that in some cases (e.g. my music library) source files can have EBU R128 gain tags alongside ordinary ReplayGain tags. If we don't instruct
ffmpeg
to strip out these tags during RG-enabled transcoding, it can confuse some client apps into thinking that the track has ReplayGain tags and should be processed accordingly.The main problem is that these R128 tags have a different scale than normal RG ones, and even when left with a value of
0
(zero) it can cause some clients to forcibly apply a whopping +5.0 dB gain to the track, causing clipping and occasional ear bleeding. :)This PR fixes it by stripping these tags out. I double-checked the result (with
mediainfo
and Foobar2000) and now there are no rogue gain tags left anymore.