gonic.service systemd service fails on Debian

[spencermathews]

I installed gonic as per the systemd section of the README, but the gonic.service unit file as written fails with the following output (from journalctl -u gonic):

Mar 08 16:52:33 raspberrypi systemd[1]: Starting Gonic service...
Mar 08 16:52:33 raspberrypi sleepservice[3998]: /bin/chown: invalid user: ‘syslog:adm’
Mar 08 16:52:33 raspberrypi systemd[1]: gonic.service: Control process exited, code=exited, status=1/FAILURE
Mar 08 16:52:33 raspberrypi systemd[1]: gonic.service: Failed with result 'exit-code'.
Mar 08 16:52:33 raspberrypi systemd[1]: Failed to start Gonic service.
Mar 08 16:52:44 raspberrypi systemd[1]: gonic.service: Service RestartSec=10s expired, scheduling restart.
Mar 08 16:52:44 raspberrypi systemd[1]: gonic.service: Scheduled restart job, restart counter is at 6.
Mar 08 16:52:44 raspberrypi systemd[1]: Stopped Gonic service.

I'm running on Raspberry Pi OS (Buster). Debian (and consequently Raspberry Pi OS) uses rsyslog and lacks the syslog user referenced in the unit file:

# make sure log directory exists and owned by syslog
PermissionsStartOnly=true
ExecStartPre=/bin/mkdir -p /var/log/gonic
ExecStartPre=/bin/chown syslog:adm /var/log/gonic
ExecStartPre=/bin/chmod 755 /var/log/gonic
StandardOutput=syslog
StandardError=syslog
SyslogIdentifier=sleepservice

I believe this entire offending block can be removed since systemd services log stdout and stderr to the systemd journal by default, and without making assumptions about the system's logging.

It appears that gonic doesn't actually write to /var/log/gonic, anyway. Does it?

Lastly, FWIW, PermissionsStartOnly is also deprecated. I get the sense that the referenced section of the unit file was more or less just copied from some template without regard for its actual function.

[sentriz]

cc @IUCCA 👌

[sentriz]

thanks, I updated the docs after testing out an ubuntu install myself. any thoughts on these changes?
4b3f890