Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
fix(ci): trim short hash
  • Loading branch information
sentriz committed May 12, 2021
1 parent 8f7131e commit 6f26974
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/nightly-release.yaml
Expand Up @@ -51,7 +51,7 @@ jobs:
- name: Generate short hash
run: |
_short_hash=${{ github.sha }}
echo "SHORT_HASH=${_short_hash:7}" >> $GITHUB_ENV
echo "SHORT_HASH=${_short_hash:0:7}" >> $GITHUB_ENV
- name: Build and Push
uses: docker/build-push-action@v2
with:
Expand Down

3 comments on commit 6f26974

@jef
Copy link
Contributor

@jef jef commented on 6f26974 May 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry :(

Was this not working correctly?


Agh, I missed it... Sorry!

https://github.com/jef/streetmerchant/blob/main/.github/workflows/nightly-release.yaml#L22

@sentriz
Copy link
Owner Author

@sentriz sentriz commented on 6f26974 May 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jef

😁 no worries
yeah it seems :7 will strip the first 7 chars instead of keeping them
image

@jef
Copy link
Contributor

@jef jef commented on 6f26974 May 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, thanks for the fix and sorry for the typo 😅

Please sign in to comment.