Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad argument parsing not throwing an error with SDK v0.16 #77

Open
jspaleta opened this issue Jun 7, 2022 · 0 comments
Open

bad argument parsing not throwing an error with SDK v0.16 #77

jspaleta opened this issue Jun 7, 2022 · 0 comments

Comments

@jspaleta
Copy link
Contributor

jspaleta commented Jun 7, 2022

This appears to be a regression in v0.16 from previous releases, not sure how far back this goes.

When passing a bad argument for example "--gross icky" the output reads "Error executing blah-blah-plugin: unknown flag: --gross" but the return status is 0.

The return status should definitely be non-zero to help plugin users diagnose the problem.

This isn't solvable inside the plugins using the sdk. The sdk actually forces exits prior to any plugin specific business logic runs such as a checkArgs function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant