Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Annotation overrides for StringSlice arguments are not treated as space delimited like cmdline and env var. #56

Open
jspaleta opened this issue Jul 13, 2021 · 1 comment
Assignees

Comments

@jspaleta
Copy link
Contributor

Problem

Annotation overrides for StringSlice arguments assume a json encoding instead of using the space delimited behavior used in the arguments and environment variables.

Let's make arguments parse in a more consistent manner.

Straw proposal

  1. Arguments of cobra StringSlice type use CSV styled space delimited in al contexts.
  2. Arguments of cobra StringArray type are parsed in ENV and annotation as a json array of strings, if not parsable as json assume its a single string.
@echlebek
Copy link
Contributor

I'll have to look at this one in light of the recent StringArray merge, I don't think this was captured.

@echlebek echlebek self-assigned this Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants