Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose changes to entity configuration at info log level #4909

Open
lspxxv opened this issue Nov 7, 2022 · 2 comments
Open

Expose changes to entity configuration at info log level #4909

lspxxv opened this issue Nov 7, 2022 · 2 comments

Comments

@lspxxv
Copy link

lspxxv commented Nov 7, 2022

Feature Suggestion

A customer would like to monitor changes to entity and check configuration and would like these exposed at a less resource intensive log level.

Nov 01 17:43:22 sensu-ubuntu sensu-backend[2083]: {"action":"Update","component":"agentd","entity":"sensu-ubuntu","level":"debug","msg":"found 1 subscription(s) to unsubscribe from: [foo]","namespace":"default","time":"2022-11-01T17:43:22Z"}
Nov 01 17:43:22 sensu-ubuntu sensu-backend[2083]: {"agent":"sensu-ubuntu","component":"agentd","level":"debug","msg":"successfully unsubscribed from \"foo\"","namespace":"default","time":"2022-11-01T17:43:22Z"}

Changes to check configuration is already exposed at the info level but the logs provide little detail as to what was changed exactly at this time

Nov 01 17:45:48 sensu-ubuntu sensu-backend[2083]: {"component":"rbac","level":"debug","msg":"request authorized by the binding cluster-admin","time":"2022-11-01T17:45:48Z","zz_request":{"apiGroup":"core","apiVersion":"v2","namespace":"default","resource":"checks","resourceName":"check_cpu","username":"admin","verb":"update"}}
Nov 01 17:45:48 sensu-ubuntu sensu-backend[2083]: {"component":"store","key":"/sensu.io/checks/","level":"debug","msg":"watch revision updated to 197212 by header revision","time":"2022-11-01T17:45:48Z"}
Nov 01 17:45:48 sensu-ubuntu sensu-backend[2083]: {"component":"store","key":"/sensu.io/checks/","level":"debug","msg":"received event of type PUT","time":"2022-11-01T17:45:48Z"}
Nov 01 17:45:48 sensu-ubuntu sensu-backend[2083]: {"component":"schedulerd","level":"info","msg":"check configs updated","time":"2022-11-01T17:45:48Z"}
Nov 01 17:45:48 sensu-ubuntu sensu-backend[2083]: {"component":"schedulerd","level":"info","msg":"restarting scheduler","time":"2022-11-01T17:45:48Z"}
Nov 01 17:45:48 sensu-ubuntu sensu-backend[2083]: {"component":"schedulerd","level":"info","msg":"check schedule has not changed","name":"check_cpu","namespace":"default","scheduler_type":"interval","time":"2022-11-01T17:45:48Z"}

Possible Implementation

Context

Internal Ref - https://secure.helpscout.net/conversation/2054095592/30190?folderId=4465878

@asachs01
Copy link

Need some input from @portertech re: moving RBAC related messages to info rather than debug

@asachs01
Copy link

asachs01 commented Jan 6, 2023

System doesn't currently have this level of granularity. This would require a LOT of changes in the product to be able to support this change. As it stands, Sensu doesn't have a concept of doing a diff--we could at the very least say "Something changed".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants