Fix the keyboard key held state occurring due to bad network conditions #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey held state to distinguish from key held state which might occur under some bad network conditions. The server releases those keys that are held due to bad network conditions by analysing the time interval of key-repeat events of the corresponding keys.
ehfd
approved these changes
May 2, 2024
|
All good, except that the internal could be fine-tuned based on our experiences. Balance between excess type strokes under unstable networks vs responsiveness in interactive control (such as gaming). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference the issue numbers and reviewers
Use
#and@to tag issues and reviewers.@ehfd
Fixes #145
Explain relevant issues and how this pull request solves them
This pull request resolves the issue by replicating the solution provided in the reference https://github.com/Xpra-org/xpra/blob/a5a13a993139d9d48a60734e7bab3ec9d53c919a/xpra/server/mixins/input.py#L257.
Describe the changes in code and its dependencies and justify that they work as intended after testing
The changes are around the web interface and python server, where the client sends key-repeat event for the keys that are in key pressed state to the server. The server monitors these key-repeat event for the held keys and manages them based on the time interval of the key-repeat event sent by the client. When there's a unstable network, the server would just release those keys.
Describe alternatives you've considered
NA
Additional context
Add any other context or screenshots about the pull request here. Please describe whether you are willing to provide funding, as this will greatly accelerate your request.