Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required minimum Python version is missing from setup.py #156

Open
eldipa opened this issue May 20, 2022 · 0 comments
Open

Required minimum Python version is missing from setup.py #156

eldipa opened this issue May 20, 2022 · 0 comments

Comments

@eldipa
Copy link
Contributor

eldipa commented May 20, 2022

The call to setup on setup.py should have a keyword argument that defines the minimum Python version required for pyte.

Something like:

setup(name="pyte",
      version="0.8.1",
      packages=["pyte"],
      python_requires='>=3.7',
      ...
)

Despite setup.py defines correctly the classifiers and says it is for Python 3.7 and upwards, if no python_requires is set, no requirement exists.

I was able to install pyte version 0.8.1 on a Python 3.6 environment which it is not okay.

It may not be a super critical today, but if 0.8.2 introduces Python 3.7 syntax, it will break downstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant