Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update config to support custom http client or http.RoundTripper #174

Open
ecasilla opened this issue Aug 16, 2021 · 1 comment
Open

update config to support custom http client or http.RoundTripper #174

ecasilla opened this issue Aug 16, 2021 · 1 comment

Comments

@ecasilla
Copy link

I wanted to add request tracing for external calls. But the client library does not support augmenting the http.Client. Would it be possible to
A. Allow the users to send a custom *http.Client with a modified round tripper OR
B. Allow users to Implement the http.RoundTripper interface and send that as part of the config. Then client merges that into the http creation flow.

@prayansh
Copy link
Contributor

@ecasilla this is an interesting feature. Is this a common pattern among go libraries (i would really appreciate any examples)? If yes, then I would be happy to add this enhancement :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants