Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI hangs on rendering flowchart diagrams, but works with sequence #24

Open
ricpelo opened this issue Aug 12, 2019 · 5 comments · May be fixed by #27
Open

CLI hangs on rendering flowchart diagrams, but works with sequence #24

ricpelo opened this issue Aug 12, 2019 · 5 comments · May be fixed by #27

Comments

@ricpelo
Copy link

ricpelo commented Aug 12, 2019

It seems to be related with #14, but it's the opposite: now diagrams CLI hangs on rendering flowchart diagrams but works with sequence.

System info

  • Ubuntu 18.04.3 LTS
  • node v8.10.0

Steps to reproduce

Install CLI

$ npm install -g diagrams

Create flowchart diagram source (input.flowchart)

cat > input.flowchart <<EOF
st=>start: Start:>http://www.google.com[blank]
e=>end:>http://www.google.com
op1=>operation: My Operation
sub1=>subroutine: My Subroutine
cond=>condition: Yes
or No?:>http://www.google.com
io=>inputoutput: catch something...
para=>parallel: parallel tasks
st->op1->cond
cond(yes)->io->e
cond(no)->para
para(path1, bottom)->sub1(right)->op1
para(path2, top)->op1
EOF

Run command to render SVG

$ diagrams flowchart input.flowchart flowchart.svg

It hangs forever.

@ricpelo
Copy link
Author

ricpelo commented Aug 12, 2019

I'd just realize that the issue is in the sample input.flowchart. The following diagram source works OK as expected:

cat > input.flowchart <<EOF
st=>start: Start:>http://www.google.com[blank]
e=>end:>http://www.google.com
op1=>operation: My Operation
sub1=>subroutine: My Subroutine
cond=>condition: Yes
or No?:>http://www.google.com
io=>inputoutput: catch something...
st->op1->cond
cond(yes)->io->e
cond(no)->para
EOF

It seems to be a problem with the para nodes. After removing them from the diagram source, the issue is gone.

@akatsuki105
Copy link

I also have this problem. My flowchart contains para too. The version is 0.11.0.

@sommella
Copy link

Same for me, any news on this issue?

@Francois-Laberge-Bose
Copy link
Collaborator

@Akatsuki-py @skonvols2k Hey guys, sorry but I don't have time at the moment for looking into this. I'm a new parent at the moment and getting no sleep, nor spare time. If one of you has time to see if maybe upgrading dependencies or something helps, I can maybe make time to redeploy.

Hope you guys are having a decent time with all of the WFH.

JoshuaCrestone pushed a commit to JoshuaCrestone/diagrams that referenced this issue Apr 22, 2020
The latest version of flowchart.js uses require to load Raphael which
failed because it was not an explicit dependency. Remove rapahel-min.js
from vendors and add it as an explicit dependency.

Resolves seflless#24.
@JoshuaCrestone JoshuaCrestone linked a pull request Apr 22, 2020 that will close this issue
@JoshuaCrestone
Copy link

I've created a pull request that solves this issue by upgrading flowchart.js and making Raphael an explicit dependency. Congratulations on being a parent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants