Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have some integration tests for K/V backups with room #548

Open
theimpulson opened this issue Aug 3, 2023 · 3 comments
Open

Have some integration tests for K/V backups with room #548

theimpulson opened this issue Aug 3, 2023 · 3 comments

Comments

@theimpulson
Copy link
Collaborator

Thanks for removing. I thought about it and actually there's probably no point in removing it. We build this app with AOSP, so whatever is in AOSP gets used. Removing this here just affects our gradle builds which are dev only.

So, the testing would actually need to happen when AOSP bumps its deps. Ideally, we'd also have some integration tests for K/V backups with room. E.g. Some sample data in the repo and we try to read and compare the result with what we expect. Then just running these tests (on-device!) would already give us more peace of mine.

Originally posted by @grote in #526 (comment)

@grote
Copy link
Collaborator

grote commented Sep 22, 2023

@stevesoltys for this, we'd need test data that has a K/V backup and when restoring it, we'd need to compare the data with what the expect. But I guess we could also use app test data and do a backup of that first.

@stevesoltys
Copy link
Member

Any ideas for apps which produce K/V backups that can be included in the static test data?

@grote
Copy link
Collaborator

grote commented Sep 26, 2023

The most important one is this magic package manager sentinel where it stores the app metadata. If we would assert the existence of some of those keys and the hash of some values this would be fine I'd say.

However, for this ticket, ideally, we'd test an AOSP build on a new AOSP emulator image to be sure nothing breaks, but one step after the next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants