Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff tool does not highlight lines #555

Open
danush opened this issue Oct 31, 2018 · 7 comments
Open

Diff tool does not highlight lines #555

danush opened this issue Oct 31, 2018 · 7 comments

Comments

@danush
Copy link

danush commented Oct 31, 2018

Diff tool does not highlight lines (version 6.2.0)

I noticed the codeMarker styles are not available and it marks the wrong lines.

<DiffEditor
            value={this.state.value}
            height="1000px"
            width="1000px"
            mode={this.state.mode}
            onChange={this.onChange}
          />

issue

@SilencerWeb
Copy link

@securingsincity ?

@dancancer
Copy link

same issue

@dancancer
Copy link

dancancer commented Dec 12, 2018

figure out, highlight style need import manually
.codeMarker { background: #fff677; position: absolute; z-index: 20; }

@SilencerWeb
Copy link

@dancancer could you make a pull request? And @securingsincity could you merge it and release new version?

@ganesh-sankey
Copy link

Yeah. I am also facing the same issue

@securingsincity
Copy link
Owner

I can add this but I'm not sure how we would want to import styles. Currently this library doesn't export any styles. Do people have thoughts on how to best do this? or does it make more sense to add this as a requirement to using the diff library?

@calthomson
Copy link

I also got hung up on this issue. I've added a sandbox that imports the missing styles explicitly:

https://codesandbox.io/s/825n0z60ol?fontsize=14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants