-
-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable annotations (useWorker not working) #275
Comments
Try removing |
@JasonEtco does @SidneyNemzer 's tip help? |
@SidneyNemzer @securingsincity I haven't had a chance to test it, I ended up going with a different component for my needs. Sorry! For what its worth, I had gone through iterations of trying each one individually which didn't do the trick. |
@securingsincity, I can confirm that @SidneyNemzer tip works:
successfully disables the worker. Looking forward to the eslint babel-eslint change upstream. |
You've peaked my interest @mattblackdev. Has Ace switched to using ESLint? I haven't seen anything about that being completed on the Ace repo. |
+1 |
is disabling all annotations for me |
yeah, this works |
We are also encountering this issue in our codebase. We have the following component: <AceEditor
mode={aceModes[mode] || 'text'}
className={`pf-c-form-control ${className}`}
theme="github"
onChange={debounce(onChange, 250)}
value={value}
onFocus={onFocus}
onBlur={onBlur}
name={`${id}-editor` || 'code-editor'}
editorProps={{ $blockScrolling: true }}
fontSize={16}
width="100%"
height={height}
hasErrors={hasErrors}
setOptions={{
readOnly,
highlightActiveLine: !readOnly,
highlightGutterLine: !readOnly,
useWorker: false,
showPrintMargin: false,
}}
commands={[
{
name: 'escape',
bindKey: { win: 'Esc', mac: 'Esc' },
exec: () => {
wrapper.current.focus();
},
},
{
name: 'tab escape',
bindKey: { win: 'Shift-Tab', mac: 'Shift-Tab' },
exec: () => {
wrapper.current.focus();
},
},
]}
ref={editor}
/> However when I introspect from Chrome dev tools the
|
Heyo 馃憢 I'm having trouble disabling the annotations. After searching through some issues, I've tried out the following:
As I understand it, setting either
setOptions.useWorker
oreditorProps.$useWorker
tofalse
should disable annotations and linting entirely, but it just isn't working. Any ideas?Thanks!
The text was updated successfully, but these errors were encountered: