Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 14 support? #2018

Open
vadimwe opened this issue Jul 1, 2022 · 15 comments
Open

Angular 14 support? #2018

vadimwe opened this issue Jul 1, 2022 · 15 comments

Comments

@vadimwe
Copy link

vadimwe commented Jul 1, 2022

Issue description
Can't install. Depedencies errors

Steps to reproduce and a minimal demo of the problem

npm install @agm/core --save in Angular 14 project
_Use stackblitz.com or similar -- try this template as a starting point: https://stackblitz.com/edit/angular-google-maps-demo

What steps should we try in your demo to see the problem?

Current behavior
Depedencies errors

Expected/desired behavior
Normal install

angular-google-maps, Angular, & any other relevant dependency versions
Angular 14 (fresh)

Other information

@DaSchTour
Copy link
Contributor

Duplicate of #2008 #2000 #1987 #1938 #1932

@sistla001
Copy link

sistla001 commented Jul 21, 2022

@DaSchTour -
Is this library still maintained? Are there any plans to add support for Angular 14? We are upgrading to Angular 14 and seeing the below error -
image

@ng-druid
Copy link

ng-druid commented Aug 1, 2022

I have the same question as the others. We are currently using Angular 8 but will be upgrading to the next major release within the a few months. This library seems like it is unmaintained and dead. The upgrade path appears to be upgrading to the official material library. If this is incorrect would appreciate a response.

@DaSchTour
Copy link
Contributor

There are two options.

  1. Use the angular components google maps - with probably less features
  2. Use this fork of agm https://github.com/ng-maps/ng-maps

@danielsigl
Copy link

Hallo @sebholstein,

schöne Grüße aus Österreich. Könnten Sie bei Gelegenheit bitte einen der Pull Requests für Angular 14 Support mergen?

Pull Request: #2014

Schönes Wochenende noch!

LG,
Daniel

@maguilleng
Copy link

There are two options.

  1. Use the angular components google maps - with probably less features
  2. Use this fork of agm https://github.com/ng-maps/ng-maps

Hello @DaSchTour I'm using ng-maps fork, but seems like <map-circle editable options not work. Is that a pending feature to enable? I set draggable, editable and clickable to true but it is readonly circle. I appreciate any confirmation about this. Thanks!!

@DaSchTour
Copy link
Contributor

@maguilleng can you please create an issue in ng-maps repo and I'll take a look.

@jason-jason-h
Copy link

@DaSchTour Thanks for the ng-maps recommendation. I'm on AGM 1.0.0 and need o migrate it all over to ng-maps to support newer versions of Angular.

@udhayakumarcp
Copy link

Facing the same error
image

@ng-druid
Copy link

ng-druid commented Dec 6, 2022

Should be noted that ng-maps isn't a drop in replacement for agm. We ran into several issues that needed to be resolved when carrying out the migration. The API is similar but not exact.

@Amin-Karimi
Copy link

Facing the same error image

use (( npm i @amin-karimi/agm-core )) for angular 14.2

@DaSchTour
Copy link
Contributor

Should be noted that ng-maps isn't a drop in replacement for agm. We ran into several issues that needed to be resolved when carrying out the migration. The API is similar but not exact.

I had to change some API to align with new google API. You can maybe create an issue and describe the problems with migration and maybe I can do some adjustments to make migration easier.

@hvdscheer
Copy link

Is there an update on this issue? We have the same problems!

@shifas-cubet
Copy link

Same issue here

@hudsontavares
Copy link

Guys, I created a fork from this project that is Angular 14-compatible (link)

All you need is to runnpm i @hudsontavares/agm-core and replace the @agm/core references from your codebase.

I am out of time to maintain the package, at least for now (the code is at https://github.com/hudsontavares/angular-google-maps), so feel free to contribute with Angular 15 / 16 support PRs if necessary (I can find time for releasing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests