Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet core compatibility #270

Closed
ciel opened this issue Feb 24, 2016 · 13 comments
Closed

dotnet core compatibility #270

ciel opened this issue Feb 24, 2016 · 13 comments

Comments

@ciel
Copy link

ciel commented Feb 24, 2016

Is there any plan to update the references for JINT to be compatible with the new .NET Core system?

@sebastienros
Copy link
Owner

It's there, use the dnx branch. At some point I will make a single project targeting all platforms, but I am waiting for the platform support story to be final.

@ciel
Copy link
Author

ciel commented Feb 27, 2016

Thank you so much for making this wonderful library. I'm so excited to see it is still being supported and worked on.

@jonjo-manywho
Copy link

We'd love to use Jint in a .NET Core project! Are there any updates to this now that it's officially released?

@ciel
Copy link
Author

ciel commented Jul 6, 2016

Yeah, I'm also looking forward to it.

@ciel
Copy link
Author

ciel commented Jul 27, 2016

Is it at least possible to use Jint with a net451 import?

@sebastienros
Copy link
Owner

If you can't wait RavenDb has ported it already to Core. It would have been better they contribute to this repository directly, but they might have other constraints.

@ciel
Copy link
Author

ciel commented Aug 6, 2016

How can we help? Which branch is the one currently being worked on for dot net core compatibility?

@sebastienros
Copy link
Owner

I just created a netcore branch. Feel free to work on the migration and target this branch.

@sebastienros
Copy link
Owner

Targeting a specific branch will let me accept PRs from different committers even if there are issues.

@darkcamper
Copy link

Hi. I've just finished porting Jint to NetStandard 1.0 and it's currntly passing all tests except for CommonScripts.ThreeDRayTrace (and I don't really know what's happening).

The bulk of the work has been replacing many changed or non-existent methods of System.Reflection

It's in pull request #337. This is my secound github contribution and I'm not reallly used to git and pull requests and stuff yet, so if I've made any mistake just tell me and I'll try to fix it.

@sebastienros
Copy link
Owner

Done, and it's on Nuget. Targets PCL, Net Standard 1.3 and .NET 45. Thanks @darkcamper for your help.

@darkcamper
Copy link

I don't think my contribution has been really useful 😅 . Thanks for sorting out everything and releasing it so quickly! (I'll make a good use of it)

@sebastienros
Copy link
Owner

It's called motivation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants