Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify dbViewR::selectfromDB.R lines 84-101 #121

Open
famulare opened this issue Nov 8, 2019 · 1 comment
Open

Simplify dbViewR::selectfromDB.R lines 84-101 #121

famulare opened this issue Nov 8, 2019 · 1 comment
Assignees
@famulare
Labels
refactor Restructure code to improve speed/maintainability/readability/etc

Comments

@famulare
Copy link
Member

famulare commented Nov 8, 2019

The join and cleaning going on in the production flow of selectFromDB can be simplified by pointing to "shipping"."observation_with_presence_absence_result_v1". This will make it easier to maintain inputs as we modify columns for year two.
@famulare famulare added the refactor Restructure code to improve speed/maintainability/readability/etc label Nov 8, 2019
@famulare famulare self-assigned this Nov 8, 2019
@famulare famulare pinned this issue Nov 8, 2019
@famulare famulare unpinned this issue Nov 19, 2019
@devclinton
Copy link
Collaborator

Just referencing code here

https://github.com/seattleflu/incidence-mapper/blob/master/dbViewR/R/selectFromDB.R#L84-L101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@famulare famulare

Labels
refactor Restructure code to improve speed/maintainability/readability/etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@devclinton @famulare