Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out-of-Memory PAR #1952

Closed
prupireddy opened this issue Apr 22, 2024 · 3 comments
Closed

Out-of-Memory PAR #1952

prupireddy opened this issue Apr 22, 2024 · 3 comments
Labels
bug Something isn't working resolution:duplicate This issue or pull request already exists

Comments

@prupireddy
Copy link

Environment Details

  • SDV version: 1.11.0
  • Python version: 3.11.7
  • Operating System: Windows 10 Enterprise

Error Description

I have a PAR model running on a health dataset. The line synthesizer.fit() throws the following error: RuntimeError: [enforce fail at alloc_cpu.cpp:114] data. DefaultCPUAllocator: not enough memory: you tried to allocate 683656 bytes. I find this particularly surprising given that I am running this on a machine with 128 GM RAM and I just restarted it.

Steps to reproduce

For privacy reasons, I cannot send the full data and code.
Here is the traceback, though:

Traceback (most recent call last):
File "C:\Users\Pranav.Rupireddy\Documents\MillimanSynthetic\par\par.py", line 261, in
synthesizer.fit(df_input)
File "C:\Users\Pranav.Rupireddy\AppData\Local\anaconda3\Lib\site-packages\sdv\single_table\base.py", line 405, in fit
self.fit_processed_data(processed_data)
File "C:\Users\Pranav.Rupireddy\AppData\Local\anaconda3\Lib\site-packages\sdv\single_table\base.py", line 386, in fit_processed_data
self._fit(processed_data)
File "C:\Users\Pranav.Rupireddy\AppData\Local\anaconda3\Lib\site-packages\sdv\sequential\par.py", line 317, in _fit
self._fit_sequence_columns(processed_data)
File "C:\Users\Pranav.Rupireddy\AppData\Local\anaconda3\Lib\site-packages\sdv\sequential\par.py", line 303, in _fit_sequence_columns
self._model.fit_sequences(sequences, context_types, data_types)
File "C:\Users\Pranav.Rupireddy\AppData\Local\anaconda3\Lib\site-packages\deepecho\models\par.py", line 315, in fit_sequences
X.append(self._data_to_tensor(sequence['data']))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\Pranav.Rupireddy\AppData\Local\anaconda3\Lib\site-packages\deepecho\models\par.py", line 203, in _data_to_tensor
x = torch.zeros(self._data_dims)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: [enforce fail at alloc_cpu.cpp:114] data. DefaultCPUAllocator: not enough memory: you tried to allocate 683656 bytes.

@prupireddy prupireddy added bug Something isn't working new Automatic label applied to new issues labels Apr 22, 2024
@srinify srinify added under discussion Issue is currently being discussed and removed new Automatic label applied to new issues labels Apr 26, 2024
@srinify
Copy link
Contributor

srinify commented Apr 26, 2024

Hi there @prupireddy PARSynthesizer isn't super well optimized yet from a performance standpoint.

To help us prioritize this, I've created the following collection thread and I've added your situation to it: #1965

I put a suggested workaround here that I recommend trying and see if that works for you: #1965 (comment)

I'm closing this issue out for now to centralize our discussion there. Thanks! Duplicate of #1965

@srinify srinify closed this as completed Apr 26, 2024
@srinify srinify added resolution:duplicate This issue or pull request already exists and removed under discussion Issue is currently being discussed labels Apr 26, 2024
@prupireddy
Copy link
Author

prupireddy commented May 16, 2024 via email

@npatki
Copy link
Contributor

npatki commented May 17, 2024

Hi @prupireddy, thanks for the feedback and details. I think it is best to discuss on Discourse.

Since GitHub is the open source forum, we have a slightly different system on here for triaging and collecting requests. As a licensed SDV Enterprise user, you will get prioritized responses, troubleshooting, etc. from Discourse. Thanks, and apologies for any confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolution:duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants