Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move out the metadata update checks in _utils.py #1946

Open
R-Palazzo opened this issue Apr 22, 2024 · 0 comments
Open

Move out the metadata update checks in _utils.py #1946

R-Palazzo opened this issue Apr 22, 2024 · 0 comments
Labels
feature request Request for a new feature

Comments

@R-Palazzo
Copy link
Contributor

Problem Description

Both BaseSynthesizer and BaseMultiTableSynthesizer contain a method called _check_metadata_updated. This method is intended to raise a warning if the metadata has been updated before the synthesizer definition or before fitting it. We are planning to move this logic to sdv/utils/_utils.py so that it can be used widely.

Expected behavior

  • Move out _check_metadata_updated from BaseSynthesizer to sdv/utils/_utils.py
  • Rename it _check_single_table_metadata_updated
  • Move out _check_metadata_updated from BaseMultiTableSynthesizer to sdv/utils/_utils.py
  • Rename it _check_multi_table_metadata_updated
  • Update the calls in the synthesizer __init__() and fit() to use the correct method.

Additional context

Update the tests and docstring accordingly.

@R-Palazzo R-Palazzo added the feature request Request for a new feature label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

1 participant