Fix representation of categorical data types in NewRowSynthesis metric #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #397.
Reviewing the history of the file, it seems that the condition of checking for the O (object) data type was created to hard-code single quotes around the value instead of using
repr:SDMetrics/sdmetrics/single_table/new_row_synthesis.py
Lines 120 to 123 in 585290f
But now that we have it, I propose we can remove the else condition as
reprwould handle our edge cases (such as formatting strings with quotes and integers with none).Let me know if this works. Thank you very much!