Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha and Beta can be out of bounds for beta distribution causing Nans to appear #367

Open
lajohn4747 opened this issue Oct 12, 2023 · 0 comments
Labels
bug There is an error in the code that needs to be fixed

Comments

@lajohn4747
Copy link
Contributor

lajohn4747 commented Oct 12, 2023

Environment Details

Please indicate the following details about the environment in which you found the bug:

  • Copulas version: 0.9.2.dev1
  • Python version: 3.11
  • Operating System: Mac

Error Description

ppf function here returns a Nan if alpha and beta values are not within bounds (i.e. value > 0):

return self.MODEL_CLASS.ppf(U, **self._params)

This is causing issues where Nans are appearing in synthetic data where the original data does not contain nans.

Values are being passed in from here:
https://github.com/sdv-dev/SDV/blob/71d61d6e8b01808c9b5a70b4573fdc7e1749b758/sdv/single_table/copulas.py#L345

@lajohn4747 lajohn4747 added bug There is an error in the code that needs to be fixed new Automatic label applied to new issues labels Oct 12, 2023
@npatki npatki removed the new Automatic label applied to new issues label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug There is an error in the code that needs to be fixed
Projects
None yet
Development

No branches or pull requests

2 participants