Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gumbel copula probability density incorrect for theta = 1 #275

Open
LiZhongyangLi opened this issue Oct 27, 2021 · 0 comments
Open

Gumbel copula probability density incorrect for theta = 1 #275

LiZhongyangLi opened this issue Oct 27, 2021 · 0 comments
Labels
bug There is an error in the code that needs to be fixed under discussion Issue is currently being discussed

Comments

@LiZhongyangLi
Copy link

LiZhongyangLi commented Oct 27, 2021

Environment Details

  • Copulas version: 0.5.1
  • Python version: 3.6.3
  • Operating System: CentOS Linux release 7.9.2009

Error Description

When theta is 1, Gumbel copula should be reduced to the independence copula with a culumative distribution equal to uv and a probability density equal constant 1. In Copulas/copulas/bivariate/gumbel.py line 46 this is implemented as the product of u and v:

  if self.theta == 1:
            return np.multiply(U, V)

Also in the comment the class is mistakenly described as the Clayton copula:

"""Class for clayton copula model."""

Steps to reproduce

from copulas.bivariate import gumbel
g = gumbel.Gumbel()
g.theta = 1
g.probability_density(np.array([0.3,0.2]).reshape(1,2))
array([0.06])
@LiZhongyangLi LiZhongyangLi added bug There is an error in the code that needs to be fixed under discussion Issue is currently being discussed labels Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug There is an error in the code that needs to be fixed under discussion Issue is currently being discussed
Projects
None yet
Development

No branches or pull requests

1 participant