Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixed usage of n_samples_overall in get_normalized_expression #2641

Open
martinkim0 opened this issue Apr 1, 2024 · 0 comments
Open

Mixed usage of n_samples_overall in get_normalized_expression #2641

martinkim0 opened this issue Apr 1, 2024 · 0 comments

Comments

@martinkim0
Copy link
Contributor

martinkim0 commented Apr 1, 2024 •
edited

In TOTALVI.get_normalized_expression, MULTIVI.get_normalized_expression, and ContrastiveVI.get_normalized_expression, n_samples_overall just downsamples indices, while in RNASeqMixin.get_normalized_expression, it's used for the number of MC inference samples. This might be confusing for users who expect the argument to mean and do the same thing across methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martinkim0