-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for MuData 0.3 release #53
Open
gtca
wants to merge
14
commits into
mudata-0.3
Choose a base branch
from
mudata-0.3-fixes
base: mudata-0.3
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently fsspec is not a dependency. However both BufferedReader and OpenFile instances should be accepted by the HDF5 reader functions.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## mudata-0.3 #53 +/- ##
==============================================
+ Coverage 69.12% 70.19% +1.06%
==============================================
Files 14 17 +3
Lines 1671 1892 +221
==============================================
+ Hits 1155 1328 +173
- Misses 516 564 +48
|
avoid name (pandas index) sorting when adding new modalities. Resolves #46.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MuData
dimensions in__repr__()
.uns
contents for views (Support for mudata.uns? #52)mod-order
attribute inread_zarr()
(Error reading zarr file #48).var_names
in the global index when modalities are added and.var_names
are intersecting (Adding modality to MuData.mod #46)bool
when there are no null values (Numpy IndexError in muon._core.tools.mofa muon#111)