Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Coverage #10

Open
ivirshup opened this issue Dec 14, 2021 · 4 comments
Open

CI Coverage #10

ivirshup opened this issue Dec 14, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@ivirshup
Copy link
Member

It would be good to have CI track coverage, so we know what is and isn't being tested.

As an example of usefulness, #8 breaks some stuff that isn't covered by tests.

@ivirshup ivirshup added the enhancement New feature or request label Dec 14, 2021
@gtca
Copy link
Collaborator

gtca commented Dec 14, 2021

Thanks, there's this available from codecov.io now, and I've also added this workflow to update it.

@ivirshup
Copy link
Member Author

Could this run for PRs to? It's nice to see whether someone's additions are tested.

@gtca
Copy link
Collaborator

gtca commented Dec 15, 2021

I am not sure this adds a coverage comment in the pull request thread though yet.

@ivirshup
Copy link
Member Author

Might be hard to tell for a bit, looks like codecov may be down at the moment. From my PR:

[2021-12-15T19:30:25.628Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 503 - Service Unavailable - upstream connect error or disconnect/reset before headers. reset reason: local reset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants