Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming #54

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Renaming #54

wants to merge 4 commits into from

Conversation

ivirshup
Copy link
Member

@ivirshup ivirshup commented Sep 20, 2023

Closes #47

  • GeneRangesFilter -> GeneRangeFilter (since it only takes a single range)
  • CanonicalFilter -> ???
  • genes(cols=...) -> genes(columns=...) – Just to be more consistent. Could go the other way and use cols everywhere.
  • What are the canonical strand names? +, - I assume?

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finalizing names
1 participant