Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defining the main genomic coordinates for each table #33

Open
emdann opened this issue Apr 28, 2023 · 2 comments
Open

Defining the main genomic coordinates for each table #33

emdann opened this issue Apr 28, 2023 · 2 comments
Labels
enhancement New feature or request P1☕️ Medium priority
Milestone

Comments

@emdann
Copy link
Member

emdann commented Apr 28, 2023

Description of feature

For each table available via EnsemblDb (e.g. genes, promoters) we could rename the primary genomic coordinates to the format required by bioframe (e.g. chrom, start, end). This would (a) mimic the behaviour in bioconductor (where ranges make the IRange column) and (b) allow selecting columns with additional coordinates in the ibis query (e.g. add tx_seq_start column when running genes #9 ).

@emdann emdann added enhancement New feature or request P1☕️ Medium priority labels Apr 28, 2023
@nvictus
Copy link
Collaborator

nvictus commented Apr 3, 2024

You can be flexible with bioframe using the cols arguments.

bioframe.overlap(genes, df2, cols1=["seq_name", "gene_seq_start", "gene_seq_end"])

@ivirshup
Copy link
Member

ivirshup commented Apr 4, 2024

It would be nice if you didn't have to though.

ensembldb and GenomicFeatures both return a GRanges which contains seqnames, ranges, and strand, for the entity being queries (e.g. genes, transcripts). This is nice because it can be directly used with genomic range libraries.

We could also provide (maybe with opt-out) the main entity's features in a way that will automatically work with bioframe.

@ivirshup ivirshup added this to the 0.1.0 milestone Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1☕️ Medium priority
Projects
None yet
Development

No branches or pull requests

3 participants