Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auriaya - Feral Defender. #24

Open
ghost opened this issue Apr 19, 2015 · 6 comments
Open

Auriaya - Feral Defender. #24

ghost opened this issue Apr 19, 2015 · 6 comments

Comments

@ghost
Copy link

ghost commented Apr 19, 2015

Welcome script of the boss is working fine, but the script Feral Defender is still not working.
https://github.com/scriptdev2/scriptdev2-cata/blob/master/scripts/northrend/ulduar/ulduar/boss_auriaya.cpp#L268
Not working:
m_uiReviveDelayTimer for some reason does not start, I want to mention only tested at Cata.

@xfurry
Copy link
Member

xfurry commented Apr 19, 2015

Ok... I'll retest on Cata then.

@ghost
Copy link
Author

ghost commented Sep 22, 2015

I found a bug

uint32 m_uiKilledCount;

Why uint32?
Need uint32 m_uiKilledCount; replace on uint8 m_uiKilledCount;
++m_uiKilledCount; not working! Need replace

@xfurry
Copy link
Member

xfurry commented Oct 4, 2015

uint32 and uin8 doesn't make a difference.
uint32 it's the standard type, so that should be fine. Unless we are going negative I can't see any issue in that line.

I think there is a problem with Cata core, rather than script

@ghost
Copy link
Author

ghost commented Oct 4, 2015

I think there is a problem with Cata core, rather than script

Cata nothing to do with the kernel, I tested General Vezax and Freya - works great. There used uint8.
This is mistake SD2.

@ghost
Copy link
Author

ghost commented Oct 7, 2015

Substitution on uint8 also does not solve the problem. Tested in game.

@ghost
Copy link
Author

ghost commented Oct 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant