lost string when add tuning with # (sharp)

[sugizo]

api.ts

export const getTuningsForGuitar = () => ([
	{label: 'Regular', 'display': 'EBGDAE', strings: ['E4', 'B3', 'G3', 'D3', 'A2', 'E2'], tuningIdx: 0, name: 0},
	{label: 'Dropped D', 'display': 'EBGDAD', strings: ['E4', 'B3', 'G3', 'D3', 'A2', 'D2'], tuningIdx: 1, name: 1},
	{label: 'Double dropped D', display: 'DADGBD', strings: ['D4', 'A3', 'D3', 'G3', 'B2', 'D2'], tuningIdx: 2, name: 2},
	{label: 'Drop C', 'display': 'DAFCGC', strings: ['D4', 'A3', 'F3', 'C3', 'G2', 'C2'], tuningIdx: 3, name: 3},
	{label: 'Open G', 'display': 'DGDGBD', strings: ['D4', 'G3', 'D3', 'G3', 'B2', 'D2'], tuningIdx: 4, name: 4},
	{label: 'Major Third', 'display': 'ECG#ECG#', strings: ['E4', 'C4', 'G#3', 'E3', 'C3', 'G#2'], tuningIdx: 5, name: 5}
]);

[walmik]

this is a very interesting feature to add.. @sugizo ! Do you need CSS help for implementing it?

[sugizo]

what i want to achieve is to learn the scale or arpeggio with another tuning, also posted another issues about this too, perhaps CSS issues or JS issues to generate fretboard and the Fret mark
nice to have feature that can support with more or less strings e.g. 4th strings bass, 5th strings bass, 7th strings guitar, etc

ref
https://en.wikipedia.org/wiki/List_of_guitar_tunings

thanks

[walmik]

@sugizo I ve added support for this now, please take a look and let me know if it works as expected (I had to add flattened note names instead of sharps to make it work) https://scribbletune.github.io/johann/#/guitar

[sugizo]

wonthefull thanks

[sugizo]

pardon, my mistake, tested on https://scribbletune.github.io/johann, just realize it define the note with Ab not G#
while on my local with your new fixed tested it with G#, so i reopen the issue again

./src/api.ts

{
   label: 'Major Third',
   display: 'ECG#ECG#',
   strings: ['E4', 'C4', 'G#3', 'E3', 'C3', 'G#2'],
   tuningIdx: 5,
   name: 5,
 },

result : 6 strings become 5 strings with lowest note is missing

result when click 'Flip fretboard vertically' : 6 strings become 4 strings

thanks

[sugizo]

perhaps can learn from this
http://sugizo.pythonanywhere.com/music/fretboard/form_scale_in_fretboard
created using python and could share the code if you want